Migrate to Jazzy #35
Merged
Migrate to Jazzy #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-della-vedova
changed the title
Yadunund
reviewed
Oct 21, 2024
luca-della-vedova
force-pushed
the
luca/jazzy_support
branch
3 times, most recently
from
688818e to
f48d054
Compare
|
I gave a try to using clang and there are compile errors due to ros2-control ros-controls/realtime_tools#183 |
luca-della-vedova
force-pushed
the
luca/jazzy_support
branch
6 times, most recently
from
e9610ab to
100ab0c
Compare
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Co-authored-by: yadunund <yadunund@openrobotics.org> Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
luca-della-vedova
force-pushed
the
luca/jazzy_support
branch
from
100ab0c to
822ea75
Compare
This reverts commit 822ea75. Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
This reverts commit b89f839. Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Yadunund
requested changes
Nov 19, 2024
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Co-authored-by: yadunund <yadunund@gmail.com>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Yadunund <yadunund@gmail.com>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Yadunund
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the Nexus codebase to Ubuntu 24.04 and ROS 2 Jazzy. Overview of the changes below, I tried to keep the commits split, clean and self descriptive to ease the review.
Zenoh
I bumped the zenoh bridge to
1.0.0, this required a minor migration but integration tests seem to still be OK.Style
Moving to Ubuntu 24.04 brings a new uncrustify version that would result in a lot of C++ file changes. I just removed uncrustify from CI for now and will create a clean PR with it.
Lifecycle nodes
During migration I found an upstream issue in
rclcppin how timers are cleaned up that broke the workcell orchestrator. Added a workaround and a TODO in 1f0f43aCommented test
I managed to get all the tests to pass except one that however was failing already so I didn't focus on trying to get it right. I added a note in b683b1f
Test it!
All the tests other than the one that I noted above pass, including integration tests. I also did a few manual runs and it seems to be OK. Note however that this has not been tested on hardware.